Skip to content

Conversation

@MartinWheelerMT
Copy link
Collaborator

@MartinWheelerMT MartinWheelerMT commented Mar 3, 2025

What

  • Update fhir-bundle.json to add Medication resources for non-snomed codes, and additionally for when no SNOMED code is present.
  • Add test to ensure that translations are added when a Medication contains a snomed code and non-snomed codes.
  • Add test to ensure that a nullFlavor="UNK" coding block is created when no snomed codes are present in a Medication.
  • Add test files for the above tests.

Why

The GP2GP Sending Adaptor does not currently preserve non-SNOMEDCT codes when mapping CodeableConcepts.

The GP2GP Request Adaptor does preserve this codes when a SNOMEDCT code is also present in the coding block.

It is necessary as part of FRA that these are preserved when transferring a patient out of NME system.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This is the first part of the change and documentation / change log will be updated once work is complete.

…ude non-SNOMEDCT codes

* Update `fhir-bundle.json` to add `Medication` resources for non-snomed codes, and additionally for when no SNOMED code is present.
* Add test to ensure that translations are added when a `Medication` contains a snomed code and non-snomed codes.
* Add test to ensure that a `nullFlavor="UNK"` coding block is created when no snomed codes are present in a `Medication`.
* Add test files for the above tests.
Bhavesh-Patel
Bhavesh-Patel previously approved these changes Mar 3, 2025
@github-actions
Copy link

github-actions bot commented Mar 3, 2025

  • Surviving mutants in this change: 3
  • Killed mutants in this change: 9
class surviving killed
🧟uk.nhs.adaptors.gp2gp.ehr.mapper.CodeableConceptCdMapper 3 9

See https://pitest.org

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2025

@MartinWheelerMT MartinWheelerMT enabled auto-merge (squash) March 3, 2025 16:13
@MartinWheelerMT MartinWheelerMT disabled auto-merge March 5, 2025 10:34
@MartinWheelerMT MartinWheelerMT enabled auto-merge (squash) March 5, 2025 10:35
@MartinWheelerMT MartinWheelerMT merged commit d60623c into main Mar 5, 2025
15 checks passed
@MartinWheelerMT MartinWheelerMT deleted the niad-3304-add-functionality-for-non-snomed-codes-3 branch March 5, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants